Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport expression caching into the Ion 1.0 readers #677

Open
zslayton opened this issue Nov 7, 2023 · 0 comments
Open

Backport expression caching into the Ion 1.0 readers #677

zslayton opened this issue Nov 7, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@zslayton
Copy link
Contributor

zslayton commented Nov 7, 2023

The Ion 1.1 readers cache child expressions encountered while parsing containers and e-expressions. To do this, they use a reference to the bump allocator to create short lived values.

The Ion 1.0 readers have access to the allocator too, but do not currently make use of it. This means that parsing happens twice when reading containers, making it significantly slower than necessary.

Once this is done, the read_many_structs benchmarks need to be updated to instantiate Ion 1.0 readers instead of relying on the backwards compatibility of the more optimized 1.1 readers.

@zslayton zslayton added the bug Something isn't working label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant