Support optional regexp flags

[jbergstroem]

In an attempt to catch additional characters while checking for case in the subject, I ran into a limitation where I need to pass the unicode flag to RegExp():

> const strings = ["information", "Information", "Ínformation", "ínformation"];
undefined
> const old = new RegExp("^(?![A-Z]).+$", "g");
undefined
> const new = new RegExp("^(?!\\p{Lu}).+$", "gu");
undefined
> strings.forEach((s) => { console.log(`${s}: ${old.test(s)}`) });
information: true
Information: false
Ínformation: true
ínformation: false
undefined
> strings.forEach((s) => { console.log(`${s}: ${new.test(s)}`) });
information: true
Information: false
Ínformation: false
ínformation: true
undefined

I see two paths here:

1. Allow passing regex literal instead of a string to RegExp()
2. Allow users to set the RegExp() options (currently hardcoded to g)

Which one is preferred? I can take a stab at a PR.

[amannn]

Allow passing regex literal instead of a string to RegExp()

Can you elaborate how that would work?

[jbergstroem]

Allow passing regex literal instead of a string to RegExp()

Can you elaborate how that would work?

Removing the option flag:

const re = new RegExp(/^(?!\p{Lu}).+$/gu);

Edit: ..or do you mean how we would support both types in the code path?

[amannn]

So this is where we read the subjectPattern from the user:

action-semantic-pull-request/src/parseConfig.js

Line 26 in 67cbd7a

subjectPattern = ConfigParser.parseString(process.env.INPUT_SUBJECTPATTERN);

… and here we construct the regex based on it:

action-semantic-pull-request/src/validatePrTitle.js

Line 123 in 67cbd7a

const match = result.subject.match(new RegExp(subjectPattern));

I understand that we could accept another option for providing the flags:

new RegExp(subjectPattern, subjectPatternFlags)

I'd just be curious if there's another option since you've mentioned that you can think of two.