docs: update example GA workflow with PR comment #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amannn
approved these changes
Oct 7, 2022
There was a problem hiding this comment.
Oh, that's really good to know—thank you for taking the time to fix the example!
Would you mind updating the workflow we have for testing this in this repo while you're at it?
|
@amannn sure! Updated the PR |
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! Thanks for the awesome action!
When trying out the example workflow for adding comments To PR from README, I noticed that sometimes I still see the comment in PR with empty error message, which disappears after reloading the page. This is of course due to Github's finicky synchronisation, but what really happens is that comment is created each time the workflow is run but then delete immediately if PR title validation passes. This PR improves this logic by adding additional condition to only create PR comment if Semantic PR action had actually failed.