Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scopes with whitespace aren't allowed #204

Closed
jszwedko opened this issue Oct 4, 2022 · 2 comments · Fixed by #205
Closed

Scopes with whitespace aren't allowed #204

jszwedko opened this issue Oct 4, 2022 · 2 comments · Fixed by #205

Comments

@jszwedko
Copy link
Contributor

jszwedko commented Oct 4, 2022

Hey all,

We have some scopes with whitespace like new source but this action appears to be treating those as two separate scopes (I'm guessing it is just splitting on whitespace). Would it make sense to only split on newlines?

This is related to #203 where I suggest making scopes and types actual lists which would also avoid this issue.
jszwedko added a commit to jszwedko/action-semantic-pull-request that referenced this issue Oct 4, 2022
@jszwedko
feat: Allow enum options to be newline delimited only
4105a13 
Fixes: amannn#204

Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
@jszwedko jszwedko mentioned this issue Oct 4, 2022
Merged
@jszwedko
Copy link
Contributor Author

jszwedko commented Oct 4, 2022

Created #205 as one way to solve this in a backwards compatible fashion.

@jszwedko jszwedko mentioned this issue Oct 4, 2022
Open
@github-actions
Copy link

🎉 This issue has been resolved in version 5.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Allow enum options to be newline delimited only jszwedko/action-semantic-pull-request
1 participant
@jszwedko