Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any way to control the title of RevertCommit #192

Open
ccxhwmy opened this issue Jul 15, 2022 · 2 comments
Open

Is there any way to control the title of RevertCommit #192

ccxhwmy opened this issue Jul 15, 2022 · 2 comments

Comments

@ccxhwmy
Copy link

ccxhwmy commented Jul 15, 2022

Recently I'm trying to replace Semantic Pull Requests with action-semantic-pull-request, Semantic Pull Requests has config like allowRevertCommits, but I don't know how use action-semantic-pull-request to achieve the same effect, I hope action-semantic-pull-request to support tile like: Revert "feat(xxx): xxx".

@ccxhwmy
Copy link
Author

ccxhwmy commented Jul 15, 2022

I found revertPattern: /^Revert\s"([\s\S]*)"\s*This reverts commit (\w*)\./, in https://github.com/amannn/action-semantic-pull-request/blob/main/dist/index.js, it seems like action-semantic-pull-request support RevertCommit like Revert "feat(test): aaaa" This reverts commit aaaaaaa., but it does not effective.
image
image

@holic
Copy link

holic commented Oct 15, 2023

Looks like this happens because the type is checked first and throws if it fails the check:

if (!result.type) {
raiseError(
`No release type found in pull request title "${prTitle}". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/\n\n${printAvailableTypes()}`
);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants