Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add disallowScopes option #179

Merged
merged 10 commits into from May 4, 2022
Merged

feat: add disallowScopes option #179

merged 10 commits into from May 4, 2022

Conversation

jmosawy
Copy link
Contributor

@jmosawy jmosawy commented Apr 29, 2022

Resolves #176

@jmosawy jmosawy marked this pull request as ready for review April 29, 2022 00:05
@jmosawy jmosawy marked this pull request as draft April 29, 2022 00:06
@jmosawy jmosawy marked this pull request as ready for review April 29, 2022 16:04
@jmosawy
Copy link
Contributor Author

jmosawy commented Apr 29, 2022

@amannn I believe this will resolve the linked issue (#176). Would you mind please reviewing it? In the meantime, can you let me know what is the best way to test the changes on CI level? Is it possible to do so?

amannn
amannn reviewed May 3, 2022
View reviewed changes
Copy link
Owner

@amannn amannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good to me, thanks for proposing this PR!

The contributors guide has information on how to test this on CI: https://github.com/amannn/action-semantic-pull-request/blob/master/CONTRIBUTORS.md.

README.md Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
src/validatePrTitle.js Outdated Show resolved Hide resolved
src/validatePrTitle.test.js Show resolved Hide resolved
@jmosawy
Copy link
Contributor Author

jmosawy commented May 3, 2022

Looks really good to me, thanks for proposing this PR!

The contributors guide has information on how to test this on CI: https://github.com/amannn/action-semantic-pull-request/blob/master/CONTRIBUTORS.md.

Thank you @amannn for the valuable feedback. I managed to fix them all now. Apologies for making a little bit of a mess here, but hopefully next time everything would look much neater. 😄

I have a PR open in my forked version here. You can check this CI log here that shows the failed test because of including the release scope.

Let me know if there's anything else I should take care of.

@jmosawy jmosawy requested a review from amannn May 3, 2022 22:19
amannn
amannn approved these changes May 4, 2022
View reviewed changes
Copy link
Owner

@amannn amannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👏 Thank you so much for your valuable contribution @jmosawy!

@amannn amannn merged commit 6a7ed2d into amannn:master May 4, 2022
@github-actions
Copy link

github-actions bot commented May 4, 2022

🎉 This PR is included in version 4.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@jmosawy jmosawy deleted the 176-add-config-disallowScopes branch May 7, 2022 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amannn amannn amannn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add config to disallow certain scopes
2 participants
@jmosawy @amannn