feat: add ignoreLabels option to force ignore errors #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amannn Hello, could you please take a look at this? 🙏 |
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
kenji-miyake
force-pushed
the
add-ignore-label-option
branch
from
80e0ac2
to
6c82aeb
Compare
amannn
reviewed
Apr 11, 2022
There was a problem hiding this comment.
Thanks a lot for another contribution @kenji-miyake! The implementation looks pretty good, I only left some minor comments.
Co-authored-by: Jan Amann <jan@amann.me>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
kenji-miyake
commented
Apr 11, 2022
amannn
reviewed
Apr 12, 2022
Co-authored-by: Jan Amann <jan@amann.me>
Co-authored-by: Jan Amann <jan@amann.me>
kenji-miyake
force-pushed
the
add-ignore-label-option
branch
from
2cad533
to
67c0d96
Compare
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
kenji-miyake
force-pushed
the
add-ignore-label-option
branch
from
67c0d96
to
2ad53de
Compare
Merged
4 tasks
amannn
approved these changes
Apr 13, 2022
|
🎉 This PR is included in version 4.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is useful to have a feature that can force ignore errors when a certain label is added.
It can be used to support the cases shown in #159 with the
validateSingleCommitMatchesPrTitleoption enabled.I've tested this in kenji-miyake#7.