Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Ordinal handling of training and holdout data with different categories #1598

Open
tamargrey opened this issue Dec 13, 2022 · 0 comments

Comments

@tamargrey
Copy link
Contributor

There are situations where we may instantiate an Ordinal logical type for a column based on training data, and then when we see the holdout data, there may be new categories that weren't present in the training data, causing the Ordinal validation to fail.

I'm wondering if it would be worth considering a workaround in the Ordinal validation for this sort of situation. Maybe a handling that just converts new values to be nans or allows the user to specify new values in the order. That said, maybe it should be on the Woodwork user to be aware of this and handling it themself.

This issue may end up coming up in EvalML as we add the OrdinalEncoder and further increase Ordinal usage across EvalML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant