Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate nan handling in Ordinal docstring #1538

Open
tamargrey opened this issue Oct 3, 2022 · 0 comments
Open

Indicate nan handling in Ordinal docstring #1538

tamargrey opened this issue Oct 3, 2022 · 0 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@tamargrey
Copy link
Contributor

In using the Ordinal.order property as part of implementing alteryx/evalml#1389, I ended up digging into Ordinal's implementation to remind myself how nans are handled. It could be useful to others in the future to have a sentence or two in the docstring explaining how nans in Ordinal columns get handled (they aren't treated as categories) and why (because you can't include a nan in setting the categories of the category dtype in pandas).

@tamargrey tamargrey added the documentation Improvements or additions to documentation label Oct 3, 2022
@gsheni gsheni added the good first issue Good for newcomers label Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants