Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BooleanNullable Logical Type and have 1 Boolean Logical Type #1517

Open
gsheni opened this issue Sep 7, 2022 · 0 comments
Open

Remove BooleanNullable Logical Type and have 1 Boolean Logical Type #1517

gsheni opened this issue Sep 7, 2022 · 0 comments

Comments

@gsheni
Copy link
Contributor

gsheni commented Sep 7, 2022

  • We originally had BooleanNullable and Boolean because EvalML relies on estimator/classifiers that do not support the pandas boolean dtype (which is used in BooleanNullable)
  • However, a better long term solution is for Woodwork to have 1 Boolean type that supports nullable values
  • For this issue:
  1. Remove/Deprecate BooleanNullable
  2. Change the Boolean physical type from int64 to Int64
  3. Update inference logic to account for this change
  4. Verify that Featuretools and EvalML can properly handle this change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant