Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColumnSchema utils is_numeric and is_categorical only work if logical type is set #1503

Open
tamargrey opened this issue Aug 23, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@tamargrey
Copy link
Contributor

Currently the ColumnSchema utils is_numeric and is_categorical only look at the logical type when determining if a column schema is numeric or categorical in nature. In Featuretools, we often set just a "numeric" or "category" semantic tag in a column schema with no logical type in order to have the column schema be more general. Currently, those situations return False when checking is_numeric and is_categorical respectively.

Ideally, Woodwork would recognize both of those as numeric and categorical as follows:

col_schema = ColumnSchema(semantic_tags={'numeric'})
assert col_schema.is_numeric

col_schema = ColumnSchema(semantic_tags={'category'})
assert col_schema.is_categorical
@tamargrey tamargrey added the bug Something isn't working label Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant