Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep floats ending in 0 as Double instead of Integer or IntegerNullable #1496

Open
ParthivNaresh opened this issue Aug 7, 2022 · 2 comments

Comments

@ParthivNaresh
Copy link
Collaborator

ParthivNaresh commented Aug 7, 2022

Currently a column of floats ending in 0 such as [1.0, 3.0, 12.0, etc] is inferred as an Integer ltype or IntegerNullable if there are null values in it.

This should be kept as Double to support downstream uses of imputation, feature engineering, and machine learning.

@thehomebrewnerd
Copy link
Contributor

@ParthivNaresh I don't think I agree with this. If there is no information after the decimal, I believe those values should be inferred and stored as integers. If users need these numeric columns as floating points, the Double logical type should be specified rather than relying on inference.

@chukarsten
Copy link
Contributor

I think this is a particularly weird one. I agree that the most natural thing is to look at a column and realize that the numbers there are actually an integer. But I also feel, from an N=1 user perspective, when I'm working in Python and handjamming some math or something, if I put in the decimal point I'm expecting my data to be treated like a float ever after. I can see it going both ways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants