deprecate Vega wrappers and VegaLite 3 wrappers #2843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joelostblom, I'm not sure about my warning message on the Vega 5 wrappers, technically the mentioned alternative is not valid as it is for Vega Lite specifications. |
|
Great to have these warnings. For the reason you stated, I think it's better to not mention the alternative of |
* DOC: remove unused section * Disable uri-reference format check in jsonsschema (vega#2771) * Disable uri-reference format check. Consistently use same validator across codebase * Remove validation in SchemaInfo as not used anywhere and it referenced the wrong jsonschema draft * Add compatibility for older jsonschema versions * Improve comments * Simplify validate_jsonschema * Replace `iteritems` with `items` due to pandas deprecation (vega#2683) * Add changelog entry. * Bump version. * Run black and flake8. * Pin selenium in CI. Co-authored-by: Jake VanderPlas <jakevdp@google.com> Co-authored-by: Stefan Binder <binder_stefan@outlook.com> Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com>
|
Thanks for the review @binste! Merging this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides deprecation warnings for
altair.vega.v5andaltair.vegalite.v3including mentioning that the modules will be removed in Altair v5.So in practice it means that the alternative for:
and
is:
I did not add
AltairDeprecationWarningsforaltair.vegalite.v4, since it is imported when doingimport altair as alt. I was not able to distunguishfrom