New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action ran fine, but didn't pick TSX comments? #160
Comments
Hey, thanks for the feedback. I haven't much experience with TSX myself, and we're missing a test for this extension, but my initial impression is that the opening |
Hey, I have some issue with TSX comment too, A comment is { /* ..... */ } i can provide some test if needed |
Looks like we need to update |
To be more specific a comment can be |
This could be a hard issue, though, because we cannot just say that we allow any character before a TODO comment since when the programmer writes "//TODO" into a string, then the string would also match in an unexpected behavior. I also thought about a better solution because sometimes you write a comment behind code what is also currently not matched: // TODO This is being matched
function foo(): string {
let bar: string = "// TODO A TODO in a string";
return bar; // TODO This don't match but should match
} I try to make something up, but I'm open to ideas. |
So,
.tsx
extension is listed in the languages.yml file, this is my TODO comment:I already added the
IDENTIFIERS
prop the workflow file:Didn't pick the
@TODO
comment after pushing the file, but the action ran without errors.Does the comment is formatted incorrectly?
The text was updated successfully, but these errors were encountered: