Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language definition for R #117

Merged
merged 5 commits into from May 20, 2022
Merged

Add language definition for R #117

merged 5 commits into from May 20, 2022

Conversation

Moohan
Copy link
Contributor

@Moohan Moohan commented May 18, 2022

R

Comments are simply started with a #

I wasn't sure how to add a test...

@alstr
Copy link
Owner

alstr commented May 19, 2022

Great, thanks very much for the contribution!

To add a test, you just need to add a code snippet to each diff file (an addition and deletion), in the style of the existing languages.

Then in the tests file, add the appropriate tests:

def test_r_issues(self):
        self.assertEqual(count_issues_for_file_type(self.raw_issues, 'r'), 2)

The number being the number of issues you expect to see when the test runs.

I'm not personally familiar with R to write a test off the top of my head.

@Moohan
Copy link
Contributor Author

Moohan commented May 20, 2022

Tests added... not 100% sure I've done it right though, I copied the Python example as that's probably my next most familiar language.

Hopefully, I've added enough that you can fix any bits I did incorrectly?

@alstr alstr merged commit 7b645d3 into alstr:master May 20, 2022
@alstr
Copy link
Owner

alstr commented May 20, 2022

Just had to tweak a few extensions in the tests but they both pass now, so all is good. Thanks again.

@Moohan Moohan deleted the patch-1 branch May 20, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants