feat(occurrence): offset occurences to support overlapping events #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@makepanic Let me know if you want any help with this. I was considering this addon for use in my project and this was one feature I'd like to make sure it has. If you're up for pairing or any code review, let me know - more than happy to make this happen with you! Cheers! |
|
We investigated the addon but ultimately didn't, because we didn't need a full calendar. I don't know if i can find time to continue working on this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP branch to fix #20.
The packing algorithm is taken from https://stackoverflow.com/a/11323909/2131168.
It's currently looking like this:
This PR adds
columnsandcolumnto the occurrence model which get used to calculate the offset and width of each rendered occurence block.There are a couple open questions/issues: