Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a time slot at midnight duplicates the time slot in to the previous day. #160

Open
willrax opened this issue Dec 13, 2017 · 3 comments
Labels

Comments

@willrax
Copy link
Contributor

willrax commented Dec 13, 2017

Reproduction

  • Load a calendar
  • Add a time slot to the start of the day (00:00)

It seems that the day.js file is returning true for both days when determining if an occurrence lives within those two days.

@willrax willrax added the bug label Dec 13, 2017
@mcfiredrill
Copy link

confirmed
screenshot 2018-10-17 09 27 33

@mcfiredrill
Copy link

Came up with this little hack to solve it. Just subtract one minute from the endingTime being checked in the occurences computed property in addon/models/day.js

mcfiredrill@443addb#diff-f77f7664b93ad9e3650f9788a0a42433R22

Seems to be working OK so far.

@willrax
Copy link
Contributor Author

willrax commented Oct 21, 2018

hey @mcfiredrill we tried that one as well, but there was some other issue that then propagated down to some other aspect of our app. I think we did figure out some fix in the end. I no longer work at at AlphaSights but perhaps @lelelyons or @katherinlaine would be able to show what we ended up doing as the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants