-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"More" link in top navigation can't be accessed without JS #3406
Comments
Has also happened in https://govuk.zendesk.com/agent/tickets/2446037 |
@h-lame Did Whitehall admin disable SRI attributes in the end? |
"More" should probably link to a page that shows those navigation options. Then JS can prevent that link from triggering and show the dropdown for users with working JS. |
The ticket to fix this this is on our doing board. https://trello.com/c/2wYn3eJi/202-new-document-tab-does-not-display-dropdown (well, it's actually the new document tab but it's the same problem). Would be good to discuss/pair @fofr. |
@fofr I haven't removed SRI from the admin template, and it doesn't look like anyone else has either. If it's causing lots of problems because of publishers working on networks that are monkeying around with the assets then removing SRI (even though it's doing its job properly!) seems like a pragmatic workaround for the problem. It'd be good to couple that with a spike/reivew to work out the scale of the problem as I suspect it's not just the more tab or new document tab. I wouldn't be surprised if large parts of whitehall admin were not progressively enhanced at all, so fixing just the bits that have been reported won't be enough. Once we've completed that review and fixed any problems we find we should be safe to re-introduce SRI safe in the knowledge that any monkeying about with the assets will be blocked, but also the publishers will still be able to get their work done. |
When Javascript fails – eg SRI hash not accepted, network failure, JS blocked, the "More" link in the Whitehall navigation won't open and reveal the links behind it. This blocks users from completing their tasks.
https://govuk.zendesk.com/agent/tickets/2312982
The text was updated successfully, but these errors were encountered: