Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning: GDSZendesk::Client#ticket forwarding to private method ZendeskAPI::Client#ticket #1153

Closed
ChrisBAshton opened this issue Jul 28, 2023 · 1 comment

Comments

@ChrisBAshton
Copy link
Contributor

Running govuk-docker-run rake is currently very noisy:

............2023-07-28T13:38:45.245Z pid=125 tid=1mbl  WARN: Job arguments to ZendeskTicketWorker do not serialize to JSON safely. This will raise an error in
Sidekiq 7.0. See https://github.com/mperham/sidekiq/wiki/Best-Practices or raise an error today
by calling `Sidekiq.strict_args!` during Sidekiq initialization.

/govuk/support/app/workers/zendesk_ticket_worker.rb:27: warning: GDSZendesk::Client#ticket at /root/.rbenv/versions/3.1.2/lib/ruby/3.1.0/forwardable.rb:157 forwarding to private method ZendeskAPI::Client#ticket
.2023-07-28T13:38:45.283Z pid=125 tid=1mbl  WARN: Job arguments to ZendeskTicketWorker do not serialize to JSON safely. This will raise an error in
Sidekiq 7.0. See https://github.com/mperham/sidekiq/wiki/Best-Practices or raise an error today
by calling `Sidekiq.strict_args!` during Sidekiq initialization.

/govuk/support/app/workers/zendesk_ticket_worker.rb:27: warning: GDSZendesk::Client#ticket at /root/.rbenv/versions/3.1.2/lib/ruby/3.1.0/forwardable.rb:157 forwarding to private method ZendeskAPI::Client#ticket
......................./govuk/support/app/views/content_change_requests/_request_details.html.erb:133: warning: key :aria is duplicated and overwritten on line 133
2023-07-28T13:38:45.870Z pid=125 tid=1mbl  WARN: Job arguments to ZendeskTicketWorker do not serialize to JSON safely. This will raise an error in
Sidekiq 7.0. See https://github.com/mperham/sidekiq/wiki/Best-Practices or raise an error today
by calling `Sidekiq.strict_args!` during Sidekiq initialization.

/govuk/support/app/workers/zendesk_ticket_worker.rb:27: warning: GDSZendesk::Client#ticket at /root/.rbenv/versions/3.1.2/lib/ruby/3.1.0/forwardable.rb:157 forwarding to private method ZendeskAPI::Client#ticket
.2023-07-28T13:38:46.496Z pid=125 tid=1mbl  WARN: Job arguments to ZendeskTicketWorker do not serialize to JSON safely. This will raise an error in
Sidekiq 7.0. See https://github.com/mperham/sidekiq/wiki/Best-Practices or raise an error today
by calling `Sidekiq.strict_args!` during Sidekiq initialization.

/govuk/support/app/workers/zendesk_ticket_worker.rb:27: warning: GDSZendesk::Client#ticket at /root/.rbenv/versions/3.1.2/lib/ruby/3.1.0/forwardable.rb:157 forwarding to private method ZendeskAPI::Client#ticket
................................2023-07-28T13:38:47.176Z pid=125 tid=1mbl  WARN: Job arguments to ZendeskTicketWorker do not serialize to JSON safely. This will raise an error in
Sidekiq 7.0. See https://github.com/mperham/sidekiq/wiki/Best-Practices or raise an error today
by calling `Sidekiq.strict_args!` during Sidekiq initialization.

/govuk/support/app/workers/zendesk_ticket_worker.rb:27: warning: GDSZendesk::Client#ticket at /root/.rbenv/versions/3.1.2/lib/ruby/3.1.0/forwardable.rb:157 forwarding to private method ZendeskAPI::Client#ticket
............2023-07-28T13:38:48.400Z pid=125 tid=1mbl  WARN: Job arguments to ZendeskTicketWorker do not serialize to JSON safely. This will raise an error in
Sidekiq 7.0. See https://github.com/mperham/sidekiq/wiki/Best-Practices or raise an error today
by calling `Sidekiq.strict_args!` during Sidekiq initialization.

We should investigate and fix up this warning.

@ChrisBAshton
Copy link
Contributor Author

No longer appears to be a thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant