Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify aggregation functionality #1102

Open
MatMoore opened this issue Dec 18, 2017 · 0 comments
Open

Simplify aggregation functionality #1102

MatMoore opened this issue Dec 18, 2017 · 0 comments
Labels

Comments

@MatMoore
Copy link
Contributor

Moved from https://trello.com/c/l4ygDSL2/15-simplify-aggregation-functionality

What

Review if we can simplify the aggregation code. We identified a few issues when replacing facets (deprecated in Elasticsearch 1.7) with aggregates.

Why

This code was designed for an older version of elasticsearch, using the older "facet" functionality. When we upgraded, we just ported it over.

Also, when aggregating on a field in the search API you can specify:

  • scope
  • order
  • examples
  • example_scope
  • example_fields

We're not sure if we still need all this functionality. From Richard Boulton:

I think the example_scope: part of it may always be given with "query" as the value.
(Or the other way around)
If true, there'll be a big chunk of code that could be deleted there.

(example)

@MatMoore MatMoore added the API label Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant