Remove redundant cops #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rule isn't necessary as it follow rubocop defaults [1] [1]: https://github.com/rubocop-hq/rubocop/blob/898b9967d7ce8b9fe45a7e2ce2b2bd5f7740a264/config/default.yml#L432-L441
This rule does not differ from the Rubocop default [1] [1]: https://github.com/rubocop-hq/rubocop/blob/898b9967d7ce8b9fe45a7e2ce2b2bd5f7740a264/config/default.yml#L3101-L3107
I don't think we've needed this exception since Rails 4.0 see [1] [1]: alphagov/whitehall@97a5868#diff-1acd2e7e27a227829d5d14a91c863bb6
This is covered by rubocop defaults [1] [1]: https://github.com/rubocop-hq/rubocop/blob/898b9967d7ce8b9fe45a7e2ce2b2bd5f7740a264/config/default.yml#L3779-L3785
benthorner
approved these changes
Jun 3, 2020
There was a problem hiding this comment.
Nice one! Great to get rid of some more stuff. I think when I did my original audit, I only checked for ones that were disabled by default.
Regarding Style/WordArray, I can see a couple of reasons to keep it as-is:
- It's applied consistently, so we don't have to remember essentially two different rules
- It's consistent with other config that disables heuristic (count, length, etc.) behaviour
| # https://github.com/alphagov/styleguides/blob/6395a10d41c3938f4c147cda443fd83f854c3e7a/ruby.md#collections | ||
| Style/HashSyntax: | ||
| Exclude: | ||
| - 'db/schema.rb' |
There was a problem hiding this comment.
(We also ignore this file in general.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a number of cops that aren't necessary as they don't deviate from rubocops defaults. I tried this out on Content Publisher and Whitehall and saw no new issues raised by this.
I also wondered if we should remove
rubocop-govuk/config/style.yml
Lines 54 to 59 in edfe29f
Since this only differs from the rubocop defaults by applying it at lengths < 1. Arguably the most surprising occurrence of our cop is when it tells you to change
["item"]into %w[item]`. I decided against doing this on this PR as it would have an affect unlike the other ones.