Import config for rubocop-rspec #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the config used for rubocop-rspec in Content Publisher. We only use rubocop-rspec in one other repo - asset-manager - but the large number of unexplained overrides eans its config is not viable to import, although should be broadly compatible with this.
kevindew
reviewed
May 18, 2020
There was a problem hiding this comment.
Looks good - just a small comment.
Sooner or later we'll probably have to decide whether we want to apply some exclusions of feature specs to system specs
| @@ -2,7 +2,7 @@ | |||
| inherit_from: | |||
| - ./config/default.yml | |||
| - ./config/rails.yml | |||
| - ./config/rake.yml | |||
| - ./config/rspec.yml | |||
There was a problem hiding this comment.
Are you meaning to remove the rake config from here?
There was a problem hiding this comment.
Ah, forgot to mention it's included by default.
kevindew
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#73
This adds the config used for rubocop-rspec in Content Publisher.
We only use rubocop-rspec in one other repo - asset-manager - but
the large number of unexplained overrides eans its config is not
viable to import, although should be broadly compatible with this.