Do all the remaining TODOs #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
May 15, 2020 14:21
We should be able to use groups to avoid issues with this Cop, and otherwise disable it in the specific repos that have unresolvable issues with it.
This conflicts with our predominant use of has_many (300), vs. has_and_belongs_to_many (15). Although this Cop doesn't support auto-correction, it should be practical to fix the 15 issues manually - it's possible some of them aren't even necessary!
This still causes issues in some of our repos, where developers have put output statements in DB migrations. Since a human is unlikely to see the result of this output, we should go ahead and disallow this, and manually resolve silence the issue for historical files, by using a comment in the file itself (to avoid setting a precedent).
Testing against a number of apps only shows major issues in Whitehall, for which a simple substitution command should suffice. If necessary, we can always pass 'validate: false' to explicitly disable validations. Tested against: - Content Publisher - Whitehall - Search API - Email Alert API
This is an analog of Style/GuardClause, which we have enabled.
We should use the online docs instead, which are up-to-date.
richardTowers
approved these changes
May 15, 2020
|
@richardTowers thanks for reviewing - I hesitated with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #42
Please see the commits for more details.