Mark ClimateControl as a dependency (rather than dev dependency) #37
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A rake task was added in 501d7ad which relies on the ClimateControl gem. If downstream apps attempt to run the task and don't have ClimateControl installed to their own projects, it will fail: #35 (comment) It should be possible to remove the ClimateControl dependency altogether by refactoring the rake task, but that can be done in a later PR. Trello: https://trello.com/c/rnfUFP5o/2453-experiment-with-common-configuration-for-pact-tests-timebox-2-days
This fixes an issue whereby some apps may face broken builds when trying to run the `pact:verify:branch` rake task.
brucebolt
approved these changes
Apr 7, 2021
|
Thanks @ChrisBAshton. I wonder if, when we do the work to remove climate_control, that we can make this gem also not require pact and have a conditional where it only adds this task when pact is installed on a repo. My rationale is: it seems weird for apps to have a pact task without having pact available and pact is a pretty heavy dependency adding about another 15 gems by including it (one of those being rspec which is itself quite a hefty dependency) |
ChrisBAshton
added a commit
that referenced
this pull request
Apr 15, 2021
This removes a Pact test branch rake task that was never used. See #34, #36 and #37 for the code that was added, which is now removed in this commit. Trello: https://trello.com/c/rnfUFP5o/2453-experiment-with-common-configuration-for-pact-tests-timebox-2-days
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A rake task was added in 501d7ad which relies on the ClimateControl gem. If downstream apps attempt to run the task and don't have ClimateControl installed to their own projects, it will fail:
#35 (comment)
It should be possible to remove the ClimateControl dependency altogether by refactoring the rake task, but that can be done in a later PR.
Trello: https://trello.com/c/rnfUFP5o/2453-experiment-with-common-configuration-for-pact-tests-timebox-2-days