Fix focus colour for buttons #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1pretz1
approved these changes
Oct 12, 2018
alex-ju
added a commit
that referenced
this pull request
Oct 12, 2018
* Add option to send the `user_organisation` in admin analytics component (PR #577) * Add a bottom margin to the error-alert component (PR #578) * Update the way we include Javascript and Stylesheets in the admin layout component. Make sure to follow the [installation instructions](docs/install-and-use.md) (PR #571) if your using the admin layout component. * Fix background colour for focused buttons (PR #579)
Merged
tijmenb
pushed a commit
that referenced
this pull request
Oct 15, 2018
* Add option to send the `user_organisation` in admin analytics component (PR #577) * Add a bottom margin to the error-alert component (PR #578) * Update the way we include Javascript and Stylesheets in the admin layout component. Make sure to follow the [installation instructions](docs/install-and-use.md) (PR #571) if your using the admin layout component. * Fix background colour for focused buttons (PR #579)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the appropriate background colour when buttons are being focused and updates the examples to use the
<button>element by default (instead of<a>), as it's the recommended way.Before
After
Trello card
Component guide for this PR:
https://govuk-publishing-compon-pr-579.herokuapp.com/component-guide/button