Update the header #557
Merged
Update the header #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tijmenb
force-pushed
the
environment-flag
branch
from
443882d
to
700ad7e
Compare
alex-ju
reviewed
Oct 2, 2018
| <% if product_name %> | ||
| <span class="govuk-header__product-name"> | ||
| <%= product_name %> | ||
| </span> | ||
| <% end %> | ||
| </a> | ||
|
|
||
| <% unless environment == "production" %> |
There was a problem hiding this comment.
Can we move this inside the anchor so Assistive Tech users know what the environment is when they get to the landmark?
app/assets/stylesheets/govuk_publishing_components/components/_layout-header.scss
Show resolved
Hide resolved
tijmenb
commented
Oct 2, 2018
app/assets/stylesheets/govuk_publishing_components/components/_layout-header.scss
Show resolved
Hide resolved
This will not need to be configurable because all the apps that use this will be part of the "GOV.UK Publishing" product.
There's a bit of a consensus that we want to keep the red for production. Personally I super disagree - I think the production version should be a proud GOV.UK blue.
This adds the environment indicator (staging, integration, development) to the header. From user research we've seen that it might prevent confusion, especially because we currently show the tag in all interfaces.
tijmenb
force-pushed
the
environment-flag
branch
from
700ad7e
to
454a4a0
Compare
|
Aw I like the blue too. Could we maintain the customisability of the name and whether the environment label is there in this heading, but default to "Publishing"? Reason I ask is that we've been trying to use this header for the component guide itself. |
|
@kevindew let's try to keep the header consistent across the apps, including component guide. If it does look weird we can re-instate the blue. |
tijmenb
added a commit
that referenced
this pull request
Oct 4, 2018
This is to allow Signon to be called "Signon" again. We'll still use "Publishing" as the default. Follow up to #557. https://trello.com/c/05wMNlxg
tijmenb
added a commit
that referenced
this pull request
Oct 4, 2018
This is to allow Signon to be called "Signon" again. We'll still use "Publishing" as the default. Follow up to #557. https://trello.com/c/05wMNlxg
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
product_nameis no longer configurable)https://trello.com/c/05wMNlxg