Fix toggle behaviour when JS disabled #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanitabarrett
force-pushed
the
fix-no-js-toggle
branch
from
b3e0f0c
to
68189c0
Compare
vanitabarrett
force-pushed
the
fix-no-js-toggle
branch
from
68189c0
to
439548c
Compare
vanitabarrett
force-pushed
the
fix-no-js-toggle
branch
from
439548c
to
8566616
Compare
vanitabarrett
force-pushed
the
fix-no-js-toggle
branch
from
8566616
to
b3d97eb
Compare
alex-ju
approved these changes
Oct 3, 2018
added 2 commits
October 3, 2018 14:51
When JS is disabled, we want to expand all content normally hidden behind a toggle, and hide the toggle link.
When JS is disabled, we want to expand all content normally hidden behind a toggle, and hide the toggle link.
vanitabarrett
force-pushed
the
fix-no-js-toggle
branch
from
7197a34
to
e85ac26
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello: https://trello.com/c/LQKpXVSw/186-audit-components-that-use-a-toggle-and-update-to-hide-the-toggle-link-when-js-is-disabled
Previously, these components would auto-expand all contents when JS was disabled (which is good), but also continue to show the toggle link which would be confusing to users. This PR only shows the toggle link if JS is enabled.
Before (taxonomy navigation)
After (taxonomy navigation)
Before (related navigation)
After (related navigation)
Links:
https://govuk-publishing-compon-pr-551.herokuapp.com/component-guide/related_navigation
https://govuk-publishing-compon-pr-551.herokuapp.com/component-guide/taxonomy_navigation