Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'about' to schema.org article schema #482

Merged
merged 1 commit into from Aug 15, 2018

Conversation

oscarwyatt
Copy link
Contributor

@oscarwyatt oscarwyatt commented Aug 14, 2018

Adds the 'about' property for the schema.org schema for an Article with live taxons

Uses the live taxonomies to which content is tagged to generate an about section for the article schema. This is so


Component guide for this PR:
https://govuk-publishing-compon-pr-482.herokuapp.com/component-guide/

Trello
https://trello.com/c/tiEHCuAA/123-implement-adding-about-to-schemaorg-article-schema

@benthorner benthorner had a problem deploying to govuk-publishing-compon-pr-482 August 14, 2018 14:20 Failure
@benthorner benthorner had a problem deploying to govuk-publishing-compon-pr-482 August 14, 2018 14:22 Failure
@oscarwyatt oscarwyatt force-pushed the add-about-section-to-article-schema branch from d902f3c to c6d695a Compare August 14, 2018 14:29
@benthorner benthorner temporarily deployed to govuk-publishing-compon-pr-482 August 14, 2018 14:29 Inactive
@oscarwyatt oscarwyatt force-pushed the add-about-section-to-article-schema branch from c6d695a to de1cf0d Compare August 14, 2018 14:32
@benthorner benthorner temporarily deployed to govuk-publishing-compon-pr-482 August 14, 2018 14:33 Inactive
@oscarwyatt oscarwyatt changed the title Add 'about' to schema.org article schema [WIP] Add 'about' to schema.org article schema Aug 14, 2018
Add changelog entry

Test schema shorter

Appeased linter
@oscarwyatt oscarwyatt force-pushed the add-about-section-to-article-schema branch from de1cf0d to 03b0143 Compare August 14, 2018 14:56
@oscarwyatt oscarwyatt changed the title [WIP] Add 'about' to schema.org article schema Add 'about' to schema.org article schema Aug 14, 2018
@oscarwyatt oscarwyatt merged commit ceec08a into master Aug 15, 2018
@oscarwyatt oscarwyatt deleted the add-about-section-to-article-schema branch August 15, 2018 09:42
@andysellick andysellick mentioned this pull request Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants