Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom tags in head for admin layout #480

Merged
merged 3 commits into from Aug 14, 2018
Merged

Allow custom tags in head for admin layout #480

merged 3 commits into from Aug 14, 2018

Conversation

alex-ju
Copy link
Contributor

@alex-ju alex-ju commented Aug 13, 2018 •
edited

This PR allows custom tags in the <head> of admin layout. This is currently needed to load application styles in admin interfaces.

Updates gemfile.lock missed from #479 which makes Heroku fail on deploys

Example of usage in app/views/layouts/application.html.erb:

<% content_for :head do %>
<%= stylesheet_link_tag "application" %>
<% end %>

<%= render 'govuk_publishing_components/components/layout_for_admin', { ... } do %>
...
<% end %>

https://govuk-publishing-compon-pr-480.herokuapp.com/component-guide/layout_for_admin

@benthorner benthorner had a problem deploying to govuk-publishing-compon-pr-480 August 13, 2018 15:48 Failure
@benthorner benthorner had a problem deploying to govuk-publishing-compon-pr-480 August 13, 2018 15:53 Failure
@benthorner benthorner temporarily deployed to govuk-publishing-compon-pr-480 August 13, 2018 15:56 Inactive
@benthorner benthorner temporarily deployed to govuk-publishing-compon-pr-480 August 13, 2018 16:00 Inactive
maxgds
maxgds approved these changes Aug 14, 2018
View reviewed changes
Copy link
Contributor

@maxgds maxgds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alex-ju alex-ju merged commit c9f9d13 into master Aug 14, 2018
@alex-ju alex-ju deleted the allow-head-in-admin-layout branch August 14, 2018 09:06
@vanitabarrett vanitabarrett mentioned this pull request Aug 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxgds maxgds maxgds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alex-ju @maxgds @benthorner