Use content_tag instead of button_tag for buttons #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a button to submit a GET form, the button element becomes an
unwanted parameter sent to the server. The button_tag helper sets two
attributes: name ('button') and type ('submit'), the former being the
cause of the issue and the latter being something we can set manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/EDDD2DYl/128-handle-when-the-user-doesnt-select-a-supertype-or-document-type
When using a button to submit a GET form, the button element becomes an
unwanted parameter sent to the server. The button_tag helper sets two
attributes: name ('button') and type ('submit'), the former being the
cause of the issue and the latter being something we can set manually.
Remember to update the CHANGELOG if your change needs to be listed in the next version of the gem.
Component guide for this PR:
https://govuk-publishing-compon-pr-[THIS PR NUMBER].herokuapp.com/component-guide/