Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase banner inverse option has a background set #3712

Open
andysellick opened this issue Nov 13, 2023 · 0 comments
Open

Phase banner inverse option has a background set #3712

andysellick opened this issue Nov 13, 2023 · 0 comments

Comments

@andysellick
Copy link
Contributor

As part of this PR I've checked to see if any other components set a background colour for their inverse option - and the phase banner does.

Components with an inverse option should not set a background colour as the inverse option is designed to work against a dark background, and we can't always know exactly what colour that background will be (it's usually GOV.UK dark blue, but it might be a dark green or something else in the future).

To fix this we'll need to check and see if the phase banner is used anywhere with the inverse option, then test if its safe to remove the background colour from it (it's not a huge job but I don't have time to do it right now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant