Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table column width changes as filtering is applied #3271

Open
nnagewad opened this issue Feb 23, 2023 · 1 comment
Open

Table column width changes as filtering is applied #3271

nnagewad opened this issue Feb 23, 2023 · 1 comment
Assignees
Labels
accessibility Accessibility issues identified bug design Design inconsistencies and quirks in progress In progress issues are being worked on but may not be a high priority.

Comments

@nnagewad
Copy link

nnagewad commented Feb 23, 2023

Issue

Description

Why it's a problem

  • Appears glitchy as width changes as end-users start entering into the filter text-field.
  • Could be a bad experience for those require the use of screen magnifiers

Reference

Screen captures

Instance 1 - Control

example1

Instance 2 - Note the change of width of each column in comparison to Control

example2

Proposal

  • Be neat to have a property to define the width of individual columns, ideally in percentage, to ensure that the column width doesn't change as end-users enter a response within the filter textfield.
@nnagewad nnagewad added bug design Design inconsistencies and quirks accessibility Accessibility issues identified labels Feb 23, 2023
@davidgisbey
Copy link
Contributor

davidgisbey commented Feb 23, 2023

For now we can override this in the stylesheets like this (.app-view-organisation-index__table is a wrapper)

.app-view-organisation-index__table .govuk-table {
  table-layout: fixed;
}

And can manually set columns width with something like


.app-view-organisation-index__table .govuk-table__row .govuk-table__header:nth-child(1) {
  width: 10%;
}

.app-view-organisation-index__table .govuk-table__row .govuk-table__header:nth-child(2) {
  width: 30%;
}

.app-view-organisation-index__table .govuk-table__row .govuk-table__header:nth-child(3) {

  width: 30%;
}

.app-view-organisation-index__table .govuk-table__row .govuk-table__header:nth-child(4) {
  width: 10%;
}

.app-view-organisation-index__table .govuk-table__row .govuk-table__header:nth-child(5) {
  width: 20%;
}

It would def be a nice to have though if we could configure column width and the filter didn't dynamically adjust column size

@andysellick andysellick added the in progress In progress issues are being worked on but may not be a high priority. label Mar 9, 2023
@andysellick andysellick added this to To do in Component issues Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Accessibility issues identified bug design Design inconsistencies and quirks in progress In progress issues are being worked on but may not be a high priority.
Projects
Development

No branches or pull requests

4 participants