Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design issues: Intervention component -- Dismiss link #3237

Open
nnagewad opened this issue Feb 6, 2023 · 4 comments
Open

Design issues: Intervention component -- Dismiss link #3237

nnagewad opened this issue Feb 6, 2023 · 4 comments
Assignees
Labels
design Design inconsistencies and quirks in progress In progress issues are being worked on but may not be a high priority.

Comments

@nnagewad
Copy link

nnagewad commented Feb 6, 2023

Component in question

Intervention component with dismiss link

Issue

  • There is an underline between the icon and "h"

Screenshot

Screenshot 2023-02-06 at 16 18 02

Proposed solution

  • Remove underline between the icon and "h"
@nnagewad nnagewad added the design Design inconsistencies and quirks label Feb 6, 2023
@nnagewad
Copy link
Author

nnagewad commented Feb 6, 2023

This may be an opportunity to rethink this. Should it be styled like a link? Or should it be more aligned to the call-to-actions within the Accordion?

Screenshots

Base state

Screenshot 2023-02-06 at 16 30 08

Hover state

Screenshot 2023-02-06 at 16 30 36

Focus state

Screenshot 2023-02-06 at 16 30 45

@monicacrusellasfanlo
Copy link

This actually made me think about the way we deal with wrapped links in the related content section too: https://www.gov.uk/guidance/appoint-someone-to-deal-with-customs-on-your-behalf

Screen.Recording.2023-02-06.at.16.51.51.mov

I think the hide this suggestion and Show 10 more should not be links. When styled like links it gives the impression that it will open a new page. I'd probably use the accordion styling instead.

@andysellick andysellick added the in progress In progress issues are being worked on but may not be a high priority. label Apr 27, 2023
@andysellick andysellick added this to To do in Component issues Apr 27, 2023
@JamesCGDS
Copy link
Contributor

Hi @nnagewad @monicacrusellasfanlo, sorry for the delay in getting round to this. Just wanted to check in and ask if a decision was reached on whether we want to just tweak this to remove the extra underline or rethink the component?

@nnagewad
Copy link
Author

nnagewad commented Jun 7, 2024

@JamesCGDS lets start by removing the extra underline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design inconsistencies and quirks in progress In progress issues are being worked on but may not be a high priority.
Projects
Development

No branches or pull requests

4 participants