Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make helpers follow conventions #3193

Open
andysellick opened this issue Jan 17, 2023 · 0 comments
Open

Make helpers follow conventions #3193

andysellick opened this issue Jan 17, 2023 · 0 comments
Assignees

Comments

@andysellick
Copy link
Contributor

According to the helpers conventions we're not following the helpers conventions. Specifically:

  • some applications are using presenters when they shouldn't (finder-frontend, government-frontend and smart-answers all use shared_helper.rb, for example)
  • not all helpers are named (component)_helper.rb (consequence is they are not detected by the auditing)

Unfortunately to correct this would involve a number of breaking changes and it's not actually causing huge problems right now. Maybe this needs to begin with a discussion about these conventions, why they exist and how we should handle them from now on.

@andysellick andysellick self-assigned this Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant