You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
According to the helpers conventions we're not following the helpers conventions. Specifically:
some applications are using presenters when they shouldn't (finder-frontend, government-frontend and smart-answers all use shared_helper.rb, for example)
not all helpers are named (component)_helper.rb (consequence is they are not detected by the auditing)
Unfortunately to correct this would involve a number of breaking changes and it's not actually causing huge problems right now. Maybe this needs to begin with a discussion about these conventions, why they exist and how we should handle them from now on.
The text was updated successfully, but these errors were encountered:
According to the helpers conventions we're not following the helpers conventions. Specifically:
finder-frontend
,government-frontend
andsmart-answers
all useshared_helper.rb
, for example)(component)_helper.rb
(consequence is they are not detected by the auditing)Unfortunately to correct this would involve a number of breaking changes and it's not actually causing huge problems right now. Maybe this needs to begin with a discussion about these conventions, why they exist and how we should handle them from now on.
The text was updated successfully, but these errors were encountered: