Make components CSS available to static in the component guide #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- applications include the styles for the components as part of the application's css, but static does not - this means gem components viewed in the static component guide are not styled, which can cause accessibility errors to trigger - adds logic and a couple of stylesheets to pull in the component styles if static is the application
andysellick
force-pushed
the
make-gem-components-work-in-static
branch
from
82389c4
to
b33f3ff
Compare
tijmenb
approved these changes
Apr 30, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary (and slightly ugly) measure while all the components are migrated from static into the gem. If there's a cleaner way of doing it please let me know.