Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health check convenience classes #47

Merged
merged 9 commits into from
Jul 17, 2018
Merged

Health check convenience classes #47

merged 9 commits into from
Jul 17, 2018

Conversation

thomasleese
Copy link
Contributor

This PR adds a few useful health check base classes which can be used as the basis for more specific application checks. It also improves the documentation and adds the ability to disable/enable health checks during the course of an applications lifetime.

The base classes added are:

  • Threshold check which compares a value (or a set of values) with a warning and a critical threshold
  • Sidekiq queue size check which compares the size of individual queues with thresholds
  • Sidekiq queue latency check which compares the latency of individual queues with thresholds
  • Generic Sidekiq queue check which makes it easy to have a threshold check which gets applied on each queue individually

Trello Card

This prevents the README file from growing bigger and bigger and
becoming harder to read through quickly.
This allows us to have more expressive tests.
This makes it easier to implement a class of check which compares
a value with a threshold.
@thomasleese thomasleese merged commit 3fbd11f into master Jul 17, 2018
@thomasleese thomasleese deleted the healthcheck-classes branch July 17, 2018 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants