Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm install gives warnings #660

Closed
joelanman opened this issue Jan 2, 2019 · 5 comments
Closed

npm install gives warnings #660

joelanman opened this issue Jan 2, 2019 · 5 comments

Comments

@joelanman
Copy link
Contributor

joelanman commented Jan 2, 2019

In training we have found that the warnings from npm install can confuse people, thinking that something has gone wrong.

Update as of 2/1/2019, the warnings are:

npm WARN deprecated postinstall-build@5.0.3: postinstall-build's behavior is now built into npm! You should migrate off of postinstall-build and use the new `prepare` lifecycle script with npm 5.0.0 or greater.

npm WARN deprecated kleur@2.0.2: Please upgrade to kleur@3 or migrate to 'ansi-colors' if you prefer the old syntax. Visit <https://github.com/lukeed/kleur/releases/tag/v3.0.0\> for migration path(s).

npm WARN deprecated circular-json@0.3.3: CircularJSON is in maintenance only, flatted is its successor.

npm WARN acorn-jsx@5.0.1 requires a peer of acorn@^6.0.0 but none is installed. You must install peer dependencies yourself.
@joelanman
Copy link
Contributor Author

The kleur issue is apparently fixed in Jest 24, currently in Alpha:

jestjs/jest#7430

https://github.com/facebook/jest/releases

@joelanman
Copy link
Contributor Author

circular-json is an open issue in eslint, used by standard

eslint/eslint#11052

This was referenced Jan 2, 2019
@aliuk2012
Copy link
Contributor

aliuk2012 commented Jan 2, 2019

npm WARN deprecated postinstall-build@5.0.3: postinstall-build's behavior is now built into npm! You should migrate off of postinstall-build and use the new 'prepare' lifecycle script with npm 5.0.0 or greater.

Should be addresses once this issue has closed mozilla/nunjucks#1167

@joelanman joelanman changed the title npm install give warnings npm install gives warnings Jan 2, 2019
@joelanman
Copy link
Contributor Author

joelanman commented Jan 2, 2019

The acorn warning appears to be a bug in npm:

eslint/eslint#11018 (comment)

Workaround here:

eslint/espree#393 (comment)

Might be worth considering if this is a bug in npm that might not be fixed for a while

@joelanman
Copy link
Contributor Author

I think all warnings are gone currently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants