Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the example webpack configs in our repo docs and our bundler integration tests #4966

Open
3 tasks
owenatgov opened this issue May 2, 2024 · 0 comments
Open
3 tasks
Labels
awaiting triage Needs triaging by team

Comments

@owenatgov
Copy link
Contributor

What

Figure out how to include the extra configuration in our webpack example ie: postcss, sass, babel etc into the test webpack config in our bundler integration tests (not merged into main at time of writing, currently only exist in #4961) with a view to remove the webpack example and have it only exist in our bundler integration tests.

Why

When #4961 is merged, we'll have 2 example webpack configs in govuk-frontend and it's more efficient to only have one. We know that webpack has widespread use across government but webpack by default "breaks" govuk-frontend (are these still true?) so the example is theoretically useful. The bundler test integration is intended to test our tree shaking against common bundlers, but it could also act as a reliable example of how to use these bundlers against govuk-frontend.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • We've assessed that the webpack example in the docs is still useful
  • We've integrated the docs example into the bundler example
  • We've assessed if the other bundler examples could include more information as well
@owenatgov owenatgov added the awaiting triage Needs triaging by team label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting triage Needs triaging by team
Projects
None yet
Development

No branches or pull requests

1 participant