Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move responsibilities from initAll to the components #4945

Closed
1 of 2 tasks
Tracked by #3731
36degrees opened this issue Apr 19, 2024 · 1 comment · Fixed by #4975 or alphagov/govuk-frontend-docs#443
Closed
1 of 2 tasks
Tracked by #3731

Move responsibilities from initAll to the components #4945

36degrees opened this issue Apr 19, 2024 · 1 comment · Fixed by #4975 or alphagov/govuk-frontend-docs#443
Assignees
Milestone

Comments

@36degrees
Copy link
Member

36degrees commented Apr 19, 2024

What

Move as many responsibilities from initAll to the components so that initAll is doing as little as possible.

For example, the data-module selector is only defined in initAll.

Add any new methods to the JavaScript API reference

Why

To make it easier to include the JS for components without needing to import or use the initAll function.

Who needs to know about this

Developers

Done when

  • initAll does as little as possible.
  • Any new methods are clearly documented in the JavaScript API reference
@romaricpascal
Copy link
Member

Reopening waiting for alphagov/govuk-frontend-docs#443 to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment