From eefcfaae34b2d65d544ef45a65f2dca04d2a5a9a Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 19 Dec 2022 09:01:36 +0000 Subject: [PATCH 1/2] Bump puppeteer from 19.4.0 to 19.4.1 Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 19.4.0 to 19.4.1. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json) - [Commits](https://github.com/puppeteer/puppeteer/compare/puppeteer-v19.4.0...puppeteer-v19.4.1) --- updated-dependencies: - dependency-name: puppeteer dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- package-lock.json | 40 +++++++++------------------------------- package.json | 2 +- 2 files changed, 10 insertions(+), 32 deletions(-) diff --git a/package-lock.json b/package-lock.json index 4b0c23940e..6ef0e30034 100644 --- a/package-lock.json +++ b/package-lock.json @@ -74,7 +74,7 @@ "jest-serializer-html": "^7.1.0", "lint-staged": "^13.1.0", "outdent": "^0.8.0", - "puppeteer": "^19.4.0", + "puppeteer": "^19.4.1", "sass-color-helpers": "^2.1.1", "standard": "^17.0.0", "stylelint": "^14.16.0", @@ -20399,27 +20399,26 @@ } }, "node_modules/puppeteer": { - "version": "19.4.0", - "resolved": "https://registry.npmjs.org/puppeteer/-/puppeteer-19.4.0.tgz", - "integrity": "sha512-sRzWEfFSZCCcFUJflGtYI2V7A6qK4Jht+2JiI2LZgn+Nv/LOZZsBDEaGl98ZrS8oEcUA5on4p2yJbE0nzHNzIg==", + "version": "19.4.1", + "resolved": "https://registry.npmjs.org/puppeteer/-/puppeteer-19.4.1.tgz", + "integrity": "sha512-PCnrR13B8A+VSEDXRmrNXRZbrkF1tfsI1hKSC7vs13eNS6CUD3Y4FA8SF8/VZy+Pm1kg5AggJT2Nu3HLAtGkFg==", "dev": true, "hasInstallScript": true, "dependencies": { "cosmiconfig": "8.0.0", - "devtools-protocol": "0.0.1068969", "https-proxy-agent": "5.0.1", "progress": "2.0.3", "proxy-from-env": "1.1.0", - "puppeteer-core": "19.4.0" + "puppeteer-core": "19.4.1" }, "engines": { "node": ">=14.1.0" } }, "node_modules/puppeteer-core": { - "version": "19.4.0", - "resolved": "https://registry.npmjs.org/puppeteer-core/-/puppeteer-core-19.4.0.tgz", - "integrity": "sha512-gG/jxseleZStinBn86x8r7trjcE4jcjx1hIQWOpACQhquHYMuKnrWxkzg+EDn8sN3wUtF/Ry9mtJgjM49oUOFQ==", + "version": "19.4.1", + "resolved": "https://registry.npmjs.org/puppeteer-core/-/puppeteer-core-19.4.1.tgz", + "integrity": "sha512-JHIuqtqrUAx4jGOTxXu4ilapV2jabxtVMA/e4wwFUMvtSsqK4nVBSI+Z1SKDoz7gRy/JUIc8WzmfocCa6SIZ1w==", "dev": true, "dependencies": { "cross-fetch": "3.1.5", @@ -20431,33 +20430,12 @@ "rimraf": "3.0.2", "tar-fs": "2.1.1", "unbzip2-stream": "1.4.3", - "ws": "8.10.0" + "ws": "8.11.0" }, "engines": { "node": ">=14.1.0" } }, - "node_modules/puppeteer-core/node_modules/ws": { - "version": "8.10.0", - "resolved": "https://registry.npmjs.org/ws/-/ws-8.10.0.tgz", - "integrity": "sha512-+s49uSmZpvtAsd2h37vIPy1RBusaLawVe8of+GyEPsaJTCMpj/2v8NpeK1SHXjBlQ95lQTmQofOJnFiLoaN3yw==", - "dev": true, - "engines": { - "node": ">=10.0.0" - }, - "peerDependencies": { - "bufferutil": "^4.0.1", - "utf-8-validate": "^5.0.2" - }, - "peerDependenciesMeta": { - "bufferutil": { - "optional": true - }, - "utf-8-validate": { - "optional": true - } - } - }, "node_modules/puppeteer/node_modules/cosmiconfig": { "version": "8.0.0", "resolved": "https://registry.npmjs.org/cosmiconfig/-/cosmiconfig-8.0.0.tgz", diff --git a/package.json b/package.json index 8a07b526bc..0bfa6f3cdd 100644 --- a/package.json +++ b/package.json @@ -99,7 +99,7 @@ "jest-serializer-html": "^7.1.0", "lint-staged": "^13.1.0", "outdent": "^0.8.0", - "puppeteer": "^19.4.0", + "puppeteer": "^19.4.1", "sass-color-helpers": "^2.1.1", "standard": "^17.0.0", "stylelint": "^14.16.0", From 377178189d017634f34a39a106ee07a1957c08c5 Mon Sep 17 00:00:00 2001 From: Colin Rotherham Date: Mon, 19 Dec 2022 09:07:56 +0000 Subject: [PATCH 2/2] Revert "Add delay for accessibility node list to be populated" Removing workaround fixed in `puppeteer-core` * https://github.com/puppeteer/puppeteer/issues/9404 * https://github.com/puppeteer/puppeteer/pull/9405 This reverts commit af91aae868d86f149952ed8736d13193753deaa7. --- src/govuk/components/accordion/accordion.test.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/govuk/components/accordion/accordion.test.js b/src/govuk/components/accordion/accordion.test.js index 025c5e5548..66a45be946 100644 --- a/src/govuk/components/accordion/accordion.test.js +++ b/src/govuk/components/accordion/accordion.test.js @@ -256,7 +256,6 @@ describe('/components/accordion', () => { ) await $element.click() - await page.waitForTimeout(100) await expect(getAccessibleName(page, $element)).resolves.toBe( 'Section A , Hide this section' @@ -275,7 +274,6 @@ describe('/components/accordion', () => { ) await $element.click() - await page.waitForTimeout(100) await expect(getAccessibleName(page, $element)).resolves.toBe( 'Test , Additional description , Hide this section'