From f5ce48d9ca495a9c599ed15dcd059e8154e4aeee Mon Sep 17 00:00:00 2001 From: Kevin Dew Date: Mon, 9 Nov 2020 17:36:09 +0000 Subject: [PATCH 1/4] Take an optimistic approach to versioning govuk_publishing_components This doesn't specify a maximum version for govuk_publishing_components which is done so that we don't have to re-release this gem each time a new version of govuk_publishing_components is released. As this gem only uses 2 components it seems unlikely that new versions of govuk_publishing_components would break this gem unintentionally and, given the frontend nature of the components, we'd likely need more than our minitest tests to confirm compatibility for a breaking change. If it turns out that govuk_publishing_components becomes more volatile in it's changes we may need to switch back to pessimistic versioning but I'm expecting this will just save people a chore moving forward. --- govspeak.gemspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/govspeak.gemspec b/govspeak.gemspec index ec3cf23..8525610 100644 --- a/govspeak.gemspec +++ b/govspeak.gemspec @@ -30,7 +30,7 @@ library for use in the UK Government Single Domain project' s.add_dependency "actionview", ">= 5.0", "< 7" s.add_dependency "addressable", ">= 2.3.8", "< 3" - s.add_dependency "govuk_publishing_components", ">= 23.0", "< 23.4" + s.add_dependency "govuk_publishing_components", ">= 23" s.add_dependency "htmlentities", "~> 4" s.add_dependency "i18n", "~> 0.7" s.add_dependency "kramdown", ">= 2.3.0" From 4146321b89b586cbf2a276d7d449f4528b6349be Mon Sep 17 00:00:00 2001 From: Kevin Dew Date: Mon, 9 Nov 2020 17:54:40 +0000 Subject: [PATCH 2/4] Use an optimistic I18n version The I18n gem is updated infrequently and has a rather stable API. It seems unnecessary to be using an old version (0.7) and hindering any applications that use this gem from using a newer version. --- govspeak.gemspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/govspeak.gemspec b/govspeak.gemspec index 8525610..fc64854 100644 --- a/govspeak.gemspec +++ b/govspeak.gemspec @@ -32,7 +32,7 @@ library for use in the UK Government Single Domain project' s.add_dependency "addressable", ">= 2.3.8", "< 3" s.add_dependency "govuk_publishing_components", ">= 23" s.add_dependency "htmlentities", "~> 4" - s.add_dependency "i18n", "~> 0.7" + s.add_dependency "i18n", ">= 0.7" s.add_dependency "kramdown", ">= 2.3.0" s.add_dependency "nokogiri", "~> 1.5" s.add_dependency "nokogumbo", "~> 2" From 9fe1b3dfe2ec8c4b81fa07620097fdf78527bc29 Mon Sep 17 00:00:00 2001 From: Kevin Dew Date: Mon, 9 Nov 2020 17:59:50 +0000 Subject: [PATCH 3/4] Loosen minitest dependency We only need to care that minitest isn't a new major version so we can loosen this pin to accept newer minor versions. --- govspeak.gemspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/govspeak.gemspec b/govspeak.gemspec index fc64854..22ad82f 100644 --- a/govspeak.gemspec +++ b/govspeak.gemspec @@ -39,7 +39,7 @@ library for use in the UK Government Single Domain project' s.add_dependency "rinku", "~> 2.0" s.add_dependency "sanitize", ">= 5.2.1", "< 6" - s.add_development_dependency "minitest", "~> 5.14.1" + s.add_development_dependency "minitest", "~> 5.14" s.add_development_dependency "pry-byebug" s.add_development_dependency "rake" s.add_development_dependency "rubocop-govuk", "~> 3.17.1" From cf6bfffa95e5395e8757597c88035f41153c1a1c Mon Sep 17 00:00:00 2001 From: Kevin Dew Date: Mon, 9 Nov 2020 18:05:14 +0000 Subject: [PATCH 4/4] Bump to 6.5.10 --- CHANGELOG.md | 4 ++++ lib/govspeak/version.rb | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9fd02da..9c23265 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,7 @@ +## 6.5.10 + +* Be optimistic in versions of govuk_publishing_components and i18n allowed (PR#200) + ## 6.5.9 * Adjust footnote markup to accommodate multiple references (PR#198) diff --git a/lib/govspeak/version.rb b/lib/govspeak/version.rb index b641766..adc85dc 100644 --- a/lib/govspeak/version.rb +++ b/lib/govspeak/version.rb @@ -1,3 +1,3 @@ module Govspeak - VERSION = "6.5.9".freeze + VERSION = "6.5.10".freeze end