Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky contents/print component conflicts with "Help us improve" #2068

Open
danielroseman opened this issue Apr 2, 2021 · 3 comments
Open

Comments

@danielroseman
Copy link
Contributor

Hi GOV.UK folks,

Not sure if this is still the right repo (my knowledge of the frontend architecture is a bit out of date) but I noticed this conflict on an HTML publication page when the "Help us improve" survey is expanded:

image

@andysellick
Copy link
Contributor

Thanks for this @danielroseman. Can you provide a specific URL and tell us what browser you're using? Thanks

@danielroseman
Copy link
Contributor Author

danielroseman commented Apr 11, 2021

@andysellick
Copy link
Contributor

Thanks for the details. I can't reproduce it either, but if I try hard I can make it glitch slightly. I think there's a case to be made for ditching the JS approach here and go with CSS position sticky instead. Apart from Internet Explorer the support is quite good now (caniuse).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants