From 1bfe427cce28b909de3eaedec7b0f661e6f2ec29 Mon Sep 17 00:00:00 2001 From: Michael Walker Date: Tue, 25 Jan 2022 11:14:18 +0000 Subject: [PATCH] Remove references to Transition Checker in account-api pact tests The Transition Checker has been retired, so we would like to remove the attribute. So we have to remove references in these tests first. --- CHANGELOG.md | 1 + test/account_api_test.rb | 9 +++------ 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 599456f8..6bd2d7a1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,6 @@ # unreleased +* Remove references to Transition Checker in account-api pact tests * Add both with- and without-message variants for bulk unsubscribe test helpers (for Email Alert API) * BREAKING: Add `sender_message_id` and `govuk_request_id` to bulk unsubscribe (bad request) test helper (for Email Alert API) * Add `content_id` to subscriber lists URL helper (for Email Alert API) diff --git a/test/account_api_test.rb b/test/account_api_test.rb index f32168f7..03c17d91 100644 --- a/test/account_api_test.rb +++ b/test/account_api_test.rb @@ -188,9 +188,6 @@ mfa: Pact.like(true), email: Pact.like("user@example.com"), email_verified: Pact.like(true), - services: { - transition_checker: "no", - }, ) account_api @@ -294,7 +291,7 @@ let(:path) { "/api/attributes" } describe "#get_attributes" do - let(:attribute_name) { "transition_checker_state" } + let(:attribute_name) { "feedback_consent" } it "responds with 200 OK and no attributes, if none exist" do response_body = response_body_with_session_identifier.merge(values: {}) @@ -309,7 +306,7 @@ end it "responds with 200 OK and the attributes, if some exist" do - response_body = response_body_with_session_identifier.merge(values: { attribute_name => { array: [1, 2, 3], some: { nested: "json" } } }) + response_body = response_body_with_session_identifier.merge(values: { attribute_name => true }) account_api .given("there is a valid user session, with an attribute called '#{attribute_name}'") @@ -322,7 +319,7 @@ end describe "#set_attributes" do - let(:attributes) { { transition_checker_state: { array: [1, 2, 3], some: { nested: "json" } } } } + let(:attributes) { { feedback_consent: true } } it "responds with 200 OK" do account_api