Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve some Publishing API test helper inconsistencies #982

Merged
merged 2 commits into from Feb 10, 2020
Merged

Resolve some Publishing API test helper inconsistencies #982

merged 2 commits into from Feb 10, 2020

Conversation

kevindew
Copy link
Member

Trello: https://trello.com/c/yqXt0RGc/1417-remove-documents-at-dwps-request

This resolves a couple issues with test helpers for Publishing API:

  • The stub any methods were applying only to the V2 endpoint so not covering those without a version namespace.
  • Adds a stub_any_publishing_api_unreserve_path to match the variety of other stub_any methods from Publishing API.

@kevindew
Fix stub_any_publishing_api_call methods using only V2 endpoint
c7418aa 
These stubs now apply to all Publishing API calls as one would expect
from the method name.
@kevindew
Add stub_any_publishing_api_unreserve_path test helper
895b65a 
This is one of the few stubbed methods that didn't have an any
equivalent and thus was a source of surprise.
benthorner
benthorner approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@benthorner benthorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇹🇭

@kevindew kevindew merged commit 402b90c into master Feb 10, 2020
@kevindew kevindew deleted the fix-publishing-api-inconsistencies branch February 10, 2020 14:45
@kevindew kevindew mentioned this pull request Feb 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benthorner benthorner benthorner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kevindew @benthorner