Add ability to batch search Rummager #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koetsier
reviewed
Oct 24, 2018
lib/gds_api/rummager.rb
Outdated
| searches.each_with_index do |search, index| | ||
| url_friendly_search = {} | ||
| url_friendly_search[index] = search | ||
| url_friendly_searches << url_friendly_search |
There was a problem hiding this comment.
It took me a while to understand this. Maybe clearer to use:
url_friendly_searches << { index => search }
There was a problem hiding this comment.
This would certainly work.
thomasleese
reviewed
Oct 26, 2018
lib/gds_api/rummager.rb
Outdated
| # | ||
| # # @see https://github.com/alphagov/rummager/blob/master/doc/search-api.md | ||
| def batch_search(searches, additional_headers = {}) | ||
| url_friendly_searches = [] |
There was a problem hiding this comment.
Might be clearer to do
url_friendly_searches = searches.each_with_index.map do |search, index|
{ index => search }
end
vanitabarrett
force-pushed
the
batch-search-rummager
branch
2 times, most recently
from
5d5b0e4
to
678e9f2
Compare
thomasleese
approved these changes
Oct 31, 2018
vanitabarrett
force-pushed
the
batch-search-rummager
branch
from
678e9f2
to
9f374e2
Compare
This commit enables the new batch search endpoint to be called on Rummager, where each of the individual queries to be batched is encoded in a readable string as part of the query string. Co-authored-by: Oscar Wyatt <oscar.wyatt@digital.cabinet-office.gov.uk>
vanitabarrett
force-pushed
the
batch-search-rummager
branch
from
9f374e2
to
cc3286f
Compare
vanitabarrett
changed the title
|
Note: this is all ready to go, but we want to hold off merging this until the Rummager change has been merged. |
vanitabarrett
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables the new batch search endpoint to be called on Rummager, where each of the individual queries to be batched is encoded in a readable string as part of the query string.
Co-authored-by: Oscar Wyatt oscar.wyatt@digital.cabinet-office.gov.uk
Trello: https://trello.com/c/QlPhl3wp/122-add-batchsearch-method-to-gds-api-adaptors