New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide location of downloaded zip file on windows #95

Open

mattsse opened this issue Aug 12, 2023 · 0 comments

Collaborator

mattsse commented Aug 12, 2023

on windows solc downloads are zip files, the checksums are for the zip files

https://binaries.soliditylang.org/windows-amd64/list.json

however, we extract the exe and are hashing this file in ethers-solc

TODO

add a way to get the downloaded file path like

https://binaries.soliditylang.org/windows-amd64/list.json

verifying checksums on windows will be more complex because we then also need to ensure that the unpacked file is actually the file in the zip...

mattsse mentioned this issue

fix: skip checksums on windows for now gakonst/ethers-rs#2553

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment