Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

will update to support latest pytorch? #5713

Closed
liusiye1994 opened this issue Sep 26, 2022 · 9 comments
Closed

will update to support latest pytorch? #5713

liusiye1994 opened this issue Sep 26, 2022 · 9 comments
Labels
Feature request

Comments

@liusiye1994
Copy link

pytorch has released 1.12.1 yet. Any schedule about supporting this version of torch?
@dirkgr dirkgr mentioned this issue Sep 28, 2022
Closed
@dirkgr
Copy link
Member

dirkgr commented Sep 28, 2022

#5714

I'm surprised dependabot didn't open a PR for this?

@dirkgr
Copy link
Member

dirkgr commented Sep 28, 2022

Actually, it did, but there was a problem with it. The correct PR is #5680.

@liusiye1994
Copy link
Author

Actually, it did, but there was a problem with it. The correct PR is #5680.

tks! seems some gpu tests failed?

@yukw777
Copy link

yukw777 commented Sep 30, 2022

When do you think #5680 will be released?

@dirkgr
Copy link
Member

dirkgr commented Oct 3, 2022

Yeah, I'm looking into it, but I got sick so it's a bit delayed now. Sorry! If you can think of a way to fix the tests I'd be happy to review and approve.

@dirkgr
Copy link
Member

dirkgr commented Oct 11, 2022

It's done!

@dirkgr
Copy link
Member

dirkgr commented Oct 11, 2022

Well, it's merged, but not released yet.

@dirkgr dirkgr closed this as completed Oct 11, 2022
@yukw777
Copy link

yukw777 commented Oct 13, 2022

@dirkgr thanks! any ETA on the new release?

@dirkgr
Copy link
Member

dirkgr commented Oct 19, 2022

Just made the release!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update minimum pytorch version allenai/allennlp
3 participants
@dirkgr @yukw777 @liusiye1994