Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split by week according to the second time dimension, there will be problems. #820

Open
kimmy-wang opened this issue Dec 23, 2021 · 3 comments
Labels
action requested Additional details from issue author requested

Comments

@kimmy-wang
Copy link

According to the second time dimension to split by week, there will be problems, the second split dimension is missing.

screenshot-20211223-144435

@mkuthan
Copy link
Member

mkuthan commented Dec 23, 2021

Hi @realkimmy

Could you reproduce the issue using Turnilo demo installation?
http://turnilo.app/

The link to the report on the demo helps up to investigate the issue.

@mkuthan mkuthan added the action requested Additional details from issue author requested label Dec 23, 2021
@kimmy-wang
Copy link
Author

Hi @realkimmy

Could you reproduce the issue using Turnilo demo installation? http://turnilo.app/

The link to the report on the demo helps up to investigate the issue.

I try it.

normal

$__time:TIME.overlap([2021-12-10T00:00:00Z,2021-12-17T00:00:00Z]).and($install_timestamp:NUMBER.cast(TIME).overlap([2021-12-10T00:00:00Z,2021-12-17T00:00:00Z]))

error

$__time:TIME.overlap([2021-12-10T00:00:00Z,2021-12-17T00:00:00Z]).and($install_timestamp:NUMBER.cast(TIME).overlap([2021-12-10T00:00:00Z,2021-12-17T00:00:00Z])).and(false)

@kimmy-wang
Copy link
Author

kimmy-wang commented Dec 24, 2021

Modify the relevant code in this file, and this error will appear

https://github.com/implydata/chronoshift/blob/d2ed2c76aa0cd6ed25fe933bc731644fa7e99828/src/floor-shift-ceil/floor-shift-ceil.ts#L45

function adjustDay(day: number): number {
  - return (day + 6) % 7;
  + return (day + 7) % 7;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action requested Additional details from issue author requested
Projects
None yet
Development

No branches or pull requests

2 participants