Broken release on Maven Central #481

wiget · 2022-06-02T12:57:38Z

Jar for version 1.13.10 released to Maven Central is broken in some way.

* What went wrong:
Could not apply requested plugin [id: 'pl.allegro.tech.build.axion-release', version: '1.13.10'] as it does not provide a plugin with id 'pl.allegro.tech.build.axion-release'. This is caused by an incorrect plugin implementation. Please contact the plugin author(s).
> Plugin with id 'pl.allegro.tech.build.axion-release' not found.

Jar from Gradle Plugins works without problem.

https://plugins.gradle.org/m2/pl/allegro/tech/build/axion-release-plugin/1.13.10/axion-release-plugin-1.13.10.jar has md5 hash fb245869dbbf1ebfd0eb25fe83c128fa
but https://repo1.maven.org/maven2/pl/allegro/tech/build/axion-release-plugin/1.13.10/axion-release-plugin-1.13.10.jar has md5 hash d39481b8f5dc729250d2086ae313ba72

The text was updated successfully, but these errors were encountered:

bgalek · 2022-06-02T17:13:38Z

@wiget thx for pointing out, gonna check it out as soon as possible!

bgalek · 2022-06-02T17:51:55Z

I'm trying to figure out the problem, the faster way will be to release next (snapshot) version, @wiget will you check it?:)

wiget · 2022-06-03T07:12:45Z

Sure, I can test. Just let me know version number.

bgalek · 2022-06-03T14:29:41Z

@wiget i've released v1.13.11 - please check it out - this project is not ready to use anykind of gradle plugin snapshots ;(

wiget · 2022-06-03T15:18:25Z

@bgalek comparing your last commit to Gradle documentation I think gradlePlugin should be defined outside pluginBundle

Something like this

gradlePlugin {
    testSourceSets project.sourceSets.integration
    setAutomatedPublishing(false)
    plugins {
        release {
            id = 'pl.allegro.tech.build.axion-release'
            implementationClass = 'pl.allegro.tech.build.axion.release.ReleasePlugin'
        }
    }
}

pluginBundle {
    website = 'https://github.com/allegro/axion-release-plugin'
    vcsUrl = 'https://github.com/allegro/axion-release-plugin'
    description = 'Release and version management plugin.'
    tags = ['release', 'version']
    plugins {
        release {
            displayName = 'axion-release-plugin'
        }
    }
}

bgalek · 2022-06-03T16:09:47Z

I've seen this, but during the local maven publication it looked like it didn't make any difference - if the latest version still has problems I'll try that. We need to move from build.gradle to kts so this kind of things will be type checked.

bgalek · 2022-06-04T11:16:07Z

@wiget did you manage to test latest version? :)

wiget · 2022-06-04T11:44:28Z

If you mean v1.13.11, then yes. I used this Gradle project to test it: https://github.com/wiget/axion-test

Running ./gradlew --info tasks gives

> Configure project :app
Evaluating project ':app' using build file '/work/axion-test/app/build.gradle'.
Compiling build file '/work/axion-test/app/build.gradle' using SubsetScriptTransformer.
Resource missing. [HTTP GET: https://repo.maven.apache.org/maven2/pl/allegro/tech/build/axion-release/pl.allegro.tech.build.axion-release.gradle.plugin/1.13.11/pl.allegro.tech.build.axion-release.gradle.plugin-1.13.11.pom]

FAILURE: Build failed with an exception.

* Where:
Build file '/work/axion-test/app/build.gradle' line: 13

* What went wrong:
Plugin [id: 'pl.allegro.tech.build.axion-release', version: '1.13.11'] was not found in any of the following sources:

- Gradle Core Plugins (plugin is not in 'org.gradle' namespace)
- Plugin Repositories (could not resolve plugin artifact 'pl.allegro.tech.build.axion-release:pl.allegro.tech.build.axion-release.gradle.plugin:1.13.11')
  Searched in the following repositories:
    MavenRepo

As you see metadata file for gradle plugin is missing on Maven Central.

wiget · 2022-06-04T11:45:22Z

I used gradle:7.4.2-jdk17-jammy Docker image for tests.

bgalek · 2022-06-05T16:55:26Z

@wiget I'll double checked jars published to maven local after moving gradlePlugin section it looks all right I hope it helps

bgalek · 2022-06-05T17:00:54Z

released v1.13.12,
I hope that in upcoming 1.14.0 with build-cache support and further kotlin compatibility improvements we will also move build.gradle to kts version and such dummy problems wont happen again ;)

wiget · 2022-06-06T13:55:57Z

From my testing it look like setAutomatedPublishing(false) is causing the problem.

Here is how local maven repository looks after publishToMavenLocal

└── pl
    └── allegro
        └── tech
            └── build
                └── axion-release-plugin
                    ├── 1.13.12
                    │   ├── axion-release-plugin-1.13.12.jar
                    │   ├── axion-release-plugin-1.13.12-javadoc.jar
                    │   ├── axion-release-plugin-1.13.12.module
                    │   ├── axion-release-plugin-1.13.12.pom
                    │   └── axion-release-plugin-1.13.12-sources.jar
                    └── maven-metadata-local.xml

and here with setAutomatedPublishing(true) (which is the default setting)

└── pl
    └── allegro
        └── tech
            └── build
                ├── axion-release
                │   └── pl.allegro.tech.build.axion-release.gradle.plugin
                │       ├── 1.13.12
                │       │   └── pl.allegro.tech.build.axion-release.gradle.plugin-1.13.12.pom
                │       └── maven-metadata-local.xml
                └── axion-release-plugin
                    ├── 1.13.12
                    │   ├── axion-release-plugin-1.13.12.jar
                    │   ├── axion-release-plugin-1.13.12-javadoc.jar
                    │   ├── axion-release-plugin-1.13.12.module
                    │   ├── axion-release-plugin-1.13.12.pom
                    │   └── axion-release-plugin-1.13.12-sources.jar
                    └── maven-metadata-local.xml

pl.allegro.tech.build.axion-release.gradle.plugin-1.13.12.pom it's crucial to resolve Gradle plugin id to artifact coordinates.

bgalek · 2022-06-06T13:57:35Z

and with setAutomatedPublishing(true) maven publish fails saying that there are two artifacts that ale colliding ;/

bgalek · 2022-06-06T14:06:59Z

@wiget https://github.com/allegro/axion-release-plugin/pull/486/files we can try it, as long as maven artifact won't be published (was the problem last time) I can always "withdraw" gradle portal publication

bgalek · 2022-06-06T14:39:00Z

@wiget https://github.com/allegro/axion-release-plugin/runs/6757276720?check_suite_focus=true I'm trying to distinguish artifact from plugin from the actual jars but as you see it's tricky ;(

bgalek · 2022-06-06T15:03:25Z

@wiget it looks ok now https://github.com/allegro/axion-release-plugin/runs/6757628488?check_suite_focus=true
https://plugins.gradle.org/plugin/pl.allegro.tech.build.axion-release
https://oss.sonatype.org/service/local/repositories/releases/content/pl/allegro/tech/build/axion-release-plugin/1.13.13/

bgalek · 2022-06-06T15:07:21Z

@wiget I've also updated badge to see any differences with maven/gradle fast

wiget · 2022-06-06T15:14:47Z

#487 should help for colliding artifacts

bgalek · 2022-06-06T15:19:21Z

@wiget thx, this could also be the way to go - as for now, the issue is resolved with v1.13.13 right?

wiget · 2022-06-06T15:21:12Z

Nope.

Resource missing. [HTTP GET: https://repo.maven.apache.org/maven2/pl/allegro/tech/build/axion-release/pl.allegro.tech.build.axion-release.gradle.plugin/1.13.13/pl.allegro.tech.build.axion-release.gradle.plugin-1.13.13.pom]

plugin marker is missing.

bgalek · 2022-06-06T15:24:47Z

@wiget it's 404 for me, maven central sync takes some time

wiget · 2022-06-06T15:36:58Z

After successful publication I will expect two directories here: https://repo1.maven.org/maven2/pl/allegro/tech/build/

axion-release with plugin marker (pom)
axion-release-plugin with all jars and pom

bgalek · 2022-06-06T15:44:16Z

@wiget i can't see older versions of axion-release artifact/pom in maven central so I understand we've never published it before, right?

wiget · 2022-06-06T15:48:05Z

Correct.

bgalek · 2022-06-06T15:53:16Z

I see, that was the missing puzzle!
I thought that we broke something, but it had never been there in the first place!
Your pr seems to work (i see snapshot pom that you would expect)

<dependency>
  <groupId>pl.allegro.tech.build.axion-release</groupId>
  <artifactId>pl.allegro.tech.build.axion-release.gradle.plugin</artifactId>
  <version>1.13.14-SNAPSHOT</version>
  <type>pom</type>
</dependency>

as I've already created a lot of havoc with those dummy versions, I'll create another one with your changes

bgalek · 2022-06-06T15:59:14Z

v1.13.14 released, it will take a while to sync maven central if you do not use sonatype as a taget

bgalek · 2022-06-06T16:00:58Z

https://oss.sonatype.org/service/local/repositories/releases/content/pl/allegro/tech/build/axion-release/pl.allegro.tech.build.axion-release.gradle.plugin/1.13.14/

https://oss.sonatype.org/service/local/repositories/releases/content/pl/allegro/tech/build/axion-release-plugin/1.13.14/

wiget · 2022-06-06T16:04:38Z

Works with following settings:

                maven {
                        url 'https://oss.sonatype.org/service/local/repositories/releases/content/'
                }

Will re-check against Maven Central in few hours.

wiget · 2022-06-06T17:45:11Z

Works with Maven Central too. Thank you.

bgalek self-assigned this Jun 2, 2022

bgalek added the bug label Jun 2, 2022

wiget mentioned this issue Jun 6, 2022

fix: customize pom, not create another publication #487

Merged

wiget closed this as completed Jun 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Broken release on Maven Central #481

Broken release on Maven Central #481

wiget commented Jun 2, 2022

bgalek commented Jun 2, 2022

bgalek commented Jun 2, 2022 •

edited

wiget commented Jun 3, 2022

bgalek commented Jun 3, 2022

wiget commented Jun 3, 2022 •

edited

bgalek commented Jun 3, 2022

bgalek commented Jun 4, 2022 •

edited

wiget commented Jun 4, 2022

wiget commented Jun 4, 2022

bgalek commented Jun 5, 2022

bgalek commented Jun 5, 2022

wiget commented Jun 6, 2022

bgalek commented Jun 6, 2022 •

edited

bgalek commented Jun 6, 2022 •

edited

bgalek commented Jun 6, 2022 •

edited

bgalek commented Jun 6, 2022 •

edited

bgalek commented Jun 6, 2022

wiget commented Jun 6, 2022

bgalek commented Jun 6, 2022

wiget commented Jun 6, 2022

bgalek commented Jun 6, 2022

wiget commented Jun 6, 2022 •

edited

bgalek commented Jun 6, 2022 •

edited

wiget commented Jun 6, 2022

bgalek commented Jun 6, 2022

bgalek commented Jun 6, 2022

bgalek commented Jun 6, 2022 •

edited

wiget commented Jun 6, 2022

wiget commented Jun 6, 2022

Broken release on Maven Central #481

Broken release on Maven Central #481

Comments

wiget commented Jun 2, 2022

bgalek commented Jun 2, 2022

bgalek commented Jun 2, 2022 • edited

wiget commented Jun 3, 2022

bgalek commented Jun 3, 2022

wiget commented Jun 3, 2022 • edited

bgalek commented Jun 3, 2022

bgalek commented Jun 4, 2022 • edited

wiget commented Jun 4, 2022

wiget commented Jun 4, 2022

bgalek commented Jun 5, 2022

bgalek commented Jun 5, 2022

wiget commented Jun 6, 2022

bgalek commented Jun 6, 2022 • edited

bgalek commented Jun 6, 2022 • edited

bgalek commented Jun 6, 2022 • edited

bgalek commented Jun 6, 2022 • edited

bgalek commented Jun 6, 2022

wiget commented Jun 6, 2022

bgalek commented Jun 6, 2022

wiget commented Jun 6, 2022

bgalek commented Jun 6, 2022

wiget commented Jun 6, 2022 • edited

bgalek commented Jun 6, 2022 • edited

wiget commented Jun 6, 2022

bgalek commented Jun 6, 2022

bgalek commented Jun 6, 2022

bgalek commented Jun 6, 2022 • edited

wiget commented Jun 6, 2022

wiget commented Jun 6, 2022

bgalek commented Jun 2, 2022 •

edited

wiget commented Jun 3, 2022 •

edited

bgalek commented Jun 4, 2022 •

edited

bgalek commented Jun 6, 2022 •

edited

bgalek commented Jun 6, 2022 •

edited

bgalek commented Jun 6, 2022 •

edited

bgalek commented Jun 6, 2022 •

edited

wiget commented Jun 6, 2022 •

edited

bgalek commented Jun 6, 2022 •

edited

bgalek commented Jun 6, 2022 •

edited