Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SnapshotDependenciesChecker fails for multi module project #330

Closed
mazdack opened this issue Mar 31, 2020 · 9 comments
Closed

SnapshotDependenciesChecker fails for multi module project #330

mazdack opened this issue Mar 31, 2020 · 9 comments

Comments

@mazdack
Copy link

mazdack commented Mar 31, 2020

For example you have 2 modules: api and server.
Server uses api module like this implementation(project(":api"))
Then the snapshot check fails:
> The project uses snapshot versions - can't release. Snapshots found

I think there should be possibility to ignore some dependencies.

@Kindrat
Copy link
Contributor

Kindrat commented Apr 8, 2020

Same here. All project() dependencies are breaking release.

Kindrat added a commit to Kindrat/axion-release-plugin that referenced this issue Apr 8, 2020
@dlesniakdev
Copy link

@Kindrat is your change actually releasing SNAPSHOT dependencies? That would be cool, stuck on this one.

I have similar issue but instead of ignoring SNAPSHOTs I'd rather like to have possibility to release them to full version. It's because I'd like to run ./gradlew release on whole multiproject instead of on concrete modules in proper order.

@Kindrat
Copy link
Contributor

Kindrat commented Jun 26, 2020

@dlesniakdev yeah, that was for snapshot release. All external deps are releases, while internal modules are snapshots.

@k3mist
Copy link

k3mist commented Jul 23, 2020

We have an internal plugin that we include Axion with and also encountered this issue when updating;

Downgrading Axion to 1.10.3 resolves it for us

> 1.10.3

→% gradle currentversion

> Task :currentVersion
Current Version:
Gradle Detected: 1.1.4
Axion Detected: 1.1.4
Internal Detected: 1.1.4

> Task :jar-sub:currentVersion
Current Version:
Gradle Detected: 1.1.5-SNAPSHOT
Axion Detected: 1.1.5-SNAPSHOT
Internal Detected: 1.1.5-SNAPSHOT

<= 1.10.3

→% gradle currentversion

> Task :currentVersion
Current Version:
Gradle Detected: 1.1.4
Axion Detected: 1.1.4
Internal Detected: 1.1.4

> Task :jar-sub:currentVersion
Current Version:
Gradle Detected: 1.1.4
Axion Detected: 1.1.4
Internal Detected: 1.1.4

It appears its most likely related to changes that occurred with; 7202376

But I'm not sure how we opt-out of this behavior and should have probably been opt-in instead of changing the existing default behavior

@radusuma
Copy link

Hello,

I am facing the same issue SnapshotDependenciesChecker fails for multi module project.
did anyone able to resolve it ?

@bgalek
Copy link
Collaborator

bgalek commented Oct 25, 2021

@bgalek
Copy link
Collaborator

bgalek commented Oct 25, 2021

We could marge it in next release if it helps with your issues!

@gabrieljones
Copy link
Contributor

gabrieljones commented Nov 28, 2022

I just ran into this, but only due to upgrading to gradle 7.6. On gradle 7.5.1 I did not have this problem.

Edit: Turns out my problems stemmed from having the plugin on each submodule when I really wanted it only on the root project.

@bgalek
Copy link
Collaborator

bgalek commented Nov 28, 2022

merged and released!

@bgalek bgalek closed this as completed Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants